This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix setting mismatch when doing absolute amplitude extraction#178
Merged
AurelienJaquier merged 2 commits intomainfrom Nov 21, 2024
Merged
Fix setting mismatch when doing absolute amplitude extraction#178AurelienJaquier merged 2 commits intomainfrom
AurelienJaquier merged 2 commits intomainfrom
Conversation
Change-Id: I3936f2f3b6f90bcb46738c839b75acd225d60a07
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 60.07% 52.37% -7.71%
==========================================
Files 109 124 +15
Lines 7838 10468 +2630
==========================================
+ Hits 4709 5483 +774
- Misses 3129 4985 +1856 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If name_rmp_protocol or name_Rin_protocol are set, then BPEM considers that we are doing threshold-based extraction, even if extract_absolute_amplitude is set. This PR should fix this.